-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [Sparse Float Vector] add sparse vector support to milvus components #30630
feat: [Sparse Float Vector] add sparse vector support to milvus components #30630
Conversation
@zhengbuqian E2e jenkins job failed, comment |
@zhengbuqian ut workflow job failed, comment |
6e9f1c4
to
fd1b555
Compare
@zhengbuqian E2e jenkins job failed, comment |
fd1b555
to
f344e00
Compare
f344e00
to
79e7a9e
Compare
@zhengbuqian E2e jenkins job failed, comment |
79e7a9e
to
1926b42
Compare
@zhengbuqian E2e jenkins job failed, comment |
1926b42
to
c888db7
Compare
@zhengbuqian E2e jenkins job failed, comment |
c888db7
to
b4217f5
Compare
@zhengbuqian E2e jenkins job failed, comment |
@zhengbuqian ut workflow job failed, comment |
b4217f5
to
c75897d
Compare
@zhengbuqian ut workflow job failed, comment |
c75897d
to
c1632e5
Compare
@zhengbuqian E2e jenkins job failed, comment |
@zhengbuqian ut workflow job failed, comment |
/lgtm |
Hooray! we just wait until all ut fixed before we merged |
/hold |
c1632e5
to
086418b
Compare
/unhold #30629 has been merged and I have rebased this PR onto master, this PR now contains only 1 commit and is ready to merge. |
@zhengbuqian ut workflow job failed, comment |
086418b
to
0ec700a
Compare
@zhengbuqian ut workflow job failed, comment |
milvus components, including proxy, data node to receive and write sparse float vectors to binlog, query node to handle search requests, index node to build index for sparse float column, etc. Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
0ec700a
to
2e506f0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #30630 +/- ##
==========================================
+ Coverage 80.97% 81.01% +0.03%
==========================================
Files 975 978 +3
Lines 142177 142775 +598
==========================================
+ Hits 115130 115667 +537
- Misses 23185 23239 +54
- Partials 3862 3869 +7
|
/hold |
3d5a52c
to
817c7f3
Compare
/unhold added some test coverage in a new standalone commit. let's see how that works out. |
in golang tests that uses indexcgowrapper/dataset.go to build index, Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
817c7f3
to
15af5ce
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xiaofan-luan, zhengbuqian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
add sparse float vector support to different milvus components, including proxy, data node to receive and write sparse float vectors to binlog, query node to handle search requests, index node to build index for sparse float column, etc.
#29419